Add function to pick_device based on models availability and use request.#90
Merged
Add function to pick_device based on models availability and use request.#90
Conversation
Member
Either we handle it here or inside LAMMPS. Maybe doing it inside LAMMPS makes the most sense since that's where we know about more things (in a sense this function is only picking the device type, not the device id). |
Luthaf
reviewed
Sep 17, 2025
80fdb50 to
f74171a
Compare
f74171a to
8444014
Compare
8444014 to
c124e57
Compare
Luthaf
reviewed
Sep 19, 2025
Co-authored-by: Guillaume Fraux <guillaume.fraux@epfl.ch>
Luthaf
approved these changes
Sep 19, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21
We have something similar in metatrain
Biggest question now is, how we handle multi GPU requests. We have this in LAMMPS and also would need this to replace the metatrain function. We could add another parameter?
Contributor (creator of pull-request) checklist
Reviewer checklist
📚 Download documentation for this pull-request