Allow zero-sized validation splits#1003
Merged
Merged
Conversation
pfebrer
force-pushed
the
zero-sized_validation
branch
from
9fa9ee1 to
3f0a816
Compare
pfebrer
approved these changes
Jan 21, 2026
Contributor
pfebrer
left a comment
pfebrer
left a comment
There was a problem hiding this comment.
Thanks! I think this doesn't solve the linked issue, but it for sure fixes a bug 👍 I think previously validation sets of 0 weren't allowed, and then we forgot to update this when we allowed them.
Contributor
|
cscs-ci run |
Contributor
|
cscs-ci run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #999
The BaseHypers schema rejected validation_set values of 0 or 0.0 due to a strict >0 constraint, even though the training pipeline already supports empty splits. This change relaxes the constraint to >=0 while still rejecting negative values.
📚 Documentation preview 📚: https://metatrain--1003.org.readthedocs.build/en/1003/