React 16.3 => migration from componentWillMount and componentWillUpdate

[fabien-h]

Not blocking at the moment ; but we have some ugly warning :)

[softwarecreations]

The warnings are not actually produced by react 16.3 or even react 16.9. They are caused by react-dom 16.9.

Reproduce deprecation warnings with 3 commands:

curl https://install.meteor.com/ | sh
cd /tmp; meteor create --react foo
cd foo; meteor

Warnings produced by react 16 in the automatically generated package.json

    "react": "^16.9.0",
    "react-dom": "^16.9.0",

Finding offending code:

grep -rn ~/.meteor -e "componentWill\(Mount\|Update\)"

~/.meteor/packages/react-meteor-data/.0.2.16.w4vu92.v54d++os+web.browser+web.cordova/os/ReactMeteorData.jsx:127:  componentWillMount() {
~/.meteor/packages/react-meteor-data/.0.2.16.w4vu92.v54d++os+web.browser+web.cordova/os/ReactMeteorData.jsx:134:  componentWillUpdate(nextProps, nextState) {

react-packages/packages/react-meteor-data/ReactMeteorData.jsx

Line 127 in b55f96d

componentWillMount() {

react-packages/packages/react-meteor-data/ReactMeteorData.jsx

Line 134 in b55f96d

componentWillUpdate(nextProps, nextState) {

Temporary workaround
npm un --save react react-dom; npm i --save react@16.9 react-dom@16.8

[Twisterking]

Will there be any updates on this? Or do I have to fork it and rename it to UNSAFE_... myself?

[dburles]

#273

[filipenevola]

closing because of react-meteor-data@2.0.0 #273