Skip to content

Streamline scene key-event handling#27

Merged
mfl28 merged 2 commits intomasterfrom
feature/streamline-scene-key-event-handling
Oct 8, 2022
Merged

Streamline scene key-event handling#27
mfl28 merged 2 commits intomasterfrom
feature/streamline-scene-key-event-handling

Conversation

@mfl28
Copy link
Owner

@mfl28 mfl28 commented Oct 2, 2022

  • Streamline scene key-event handling.
  • Introduce single fire events.
  • Update image navigation key-shortcuts.
  • Add scene-key event tests.

Closes #26 .

@mfl28 mfl28 self-assigned this Oct 2, 2022
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 84.13% // Head: 85.57% // Increases project coverage by +1.44% 🎉

Coverage data is based on head (3eed1a4) compared to base (e73f4c8).
Patch coverage: 96.22% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #27      +/-   ##
============================================
+ Coverage     84.13%   85.57%   +1.44%     
- Complexity     1281     1345      +64     
============================================
  Files            89       91       +2     
  Lines          5577     5600      +23     
  Branches        505      503       -2     
============================================
+ Hits           4692     4792     +100     
+ Misses          638      547      -91     
- Partials        247      261      +14     
Impacted Files Coverage Δ
...mfl28/boundingboxeditor/controller/Controller.java 77.92% <92.85%> (+5.77%) ⬆️
...r/controller/utils/KeyCombinationEventHandler.java 100.00% <100.00%> (ø)
...er/utils/SingleFireKeyCombinationEventHandler.java 100.00% <100.00%> (ø)
...fl28/boundingboxeditor/ui/BoundingPolygonView.java 85.48% <0.00%> (+0.79%) ⬆️
...om/github/mfl28/boundingboxeditor/model/Model.java 87.85% <0.00%> (+1.42%) ⬆️
...28/boundingboxeditor/ui/BoundingShapeViewData.java 86.79% <0.00%> (+1.88%) ⬆️
...fl28/boundingboxeditor/ui/EditorImagePaneView.java 87.04% <0.00%> (+2.42%) ⬆️
.../github/mfl28/boundingboxeditor/ui/EditorView.java 100.00% <0.00%> (+2.70%) ⬆️
...hub/mfl28/boundingboxeditor/ui/ObjectTreeView.java 80.89% <0.00%> (+3.82%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

97.2% 97.2% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit 5acc75a into master Oct 8, 2022
@mfl28 mfl28 deleted the feature/streamline-scene-key-event-handling branch October 8, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streamline scene key-event handling

1 participant