Skip to content

Fix reflection and modularity errors wrt. jakarta and gson.#31

Merged
mfl28 merged 1 commit intomasterfrom
bugfix/fix-reflection-and-modularity-errors
Oct 9, 2022
Merged

Fix reflection and modularity errors wrt. jakarta and gson.#31
mfl28 merged 1 commit intomasterfrom
bugfix/fix-reflection-and-modularity-errors

Conversation

@mfl28
Copy link
Owner

@mfl28 mfl28 commented Oct 9, 2022

  • Explicitly add missing "uses" directives (that cannot be determined automatically) to jlink mergeModule section to fix modularity errors in the runtime images (-> jakarta).
  • Transform ModelEntry and BoundingBoxPredictionEntry records back to data classes as Gson does not seem to have reflective access to set the fields of records.
  • Verify the equality contract of the data classes in unit tests.

Fixes #30 .

@mfl28 mfl28 self-assigned this Oct 9, 2022
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 85.55% // Head: 85.60% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (ca99fa8) compared to base (1dcaa0b).
Patch coverage: 96.42% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
+ Coverage     85.55%   85.60%   +0.04%     
- Complexity     1345     1363      +18     
============================================
  Files            91       91              
  Lines          5600     5626      +26     
  Branches        503      509       +6     
============================================
+ Hits           4791     4816      +25     
- Misses          547      548       +1     
  Partials        262      262              
Impacted Files Coverage Δ
...dingboxeditor/model/io/restclients/ModelEntry.java 92.85% <92.85%> (-7.15%) ⬇️
...del/io/restclients/BoundingBoxPredictionEntry.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.9% 97.9% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit f0c5876 into master Oct 9, 2022
@mfl28 mfl28 deleted the bugfix/fix-reflection-and-modularity-errors branch October 9, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetching model and prediction from TorchServe server causes modularity errors/illegal reflective access

1 participant