Skip to content

Expand on instructions and link for the README #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amishn2008 wants to merge 4 commits into from
Closed

Expand on instructions and link for the README #273

amishn2008 wants to merge 4 commits into from

Conversation

@amishn2008
Copy link
Contributor

@amishn2008 amishn2008 commented Jun 8, 2025

Added extra instructions for navigation on the README

@amishn2008
Copy link
Contributor Author

amishn2008 commented Jun 8, 2025

@adisidev

@nihalzp
Copy link
Collaborator

nihalzp commented Jun 8, 2025

Thank you for working on adding support for scientific notation.

src/misc/string_to_decimal_converter.cpp is an error-prone part of the software. Please add the tests for the new cases to: tests/unit/test_string_to_decimal_converter.cpp

@nihalzp nihalzp added the feature New feature or request label Jun 8, 2025
@nihalzp nihalzp linked an issue Jun 8, 2025 that may be closed by this pull request
Allow scientific notation for CSV files #260
Open
@amishn2008 amishn2008 mentioned this pull request Jun 12, 2025
Open
@amishn2008
Copy link
Contributor Author

amishn2008 commented Jun 12, 2025 •
edited
Loading

Moved to #282

@amishn2008 amishn2008 closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adisidev adisidev

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow scientific notation for CSV files

3 participants

@amishn2008 @nihalzp @adisidev