Skip to content

Conversation

@nihalzp
Copy link
Collaborator

@nihalzp nihalzp commented Oct 14, 2025

Closes #306

The current csv parser vincentlaucsb/csv-parser parses Šibensko-kninska as ibensko-kninska in Linux/arm. As a result, it leads to mismatch between GeoJSON and CSV. Thus, we are moving to a new CSV parser.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

🚦 Performance Comparison (α=0.05, ±5%)

🗺️ Total maps34 ❌ Failed0 🚀 Speed-ups9 🐢 Slow-downs0 ⚖️ No change25

❌ Failures

None 😎

🚀 Speed-ups (9)
map main pr Δ % p
conterminous_​usa_​by_​state_​since_​1959/​conterminous_​usa_​population_​by_​state_​2020.csv 0.438±0.004 0.415±0.005 -5.2 0.000
england_​by_​region_​since_​2023/​england_​population_​by_​region_​2022.csv 1.355±0.023 1.285±0.017 -5.1 0.000
germany_​by_​state_​since_​1990/​germany_​population_​by_​state_​2011.csv 0.155±0.005 0.146±0.002 -5.6 0.000
russia_​by_​federal_​subject_​since_​2008/​russia_​population_​by_​federal_​subject_​2010.csv 1.421±0.076 1.243±0.011 -12.5 0.002
switzerland_​by_​canton_​since_​1999/​switzerland_​gdp_​in_​billion_​chf_​by_​canton_​2019.csv 0.357±0.003 0.334±0.002 -6.4 0.000
switzerland_​by_​canton_​since_​1999/​switzerland_​population_​by_​canton_​2016.csv 0.315±0.004 0.295±0.002 -6.3 0.000
tunisia_​by_​governorate_​since_​1994/​tunisia_​population_​by_​governate_​2014.csv 0.337±0.007 0.317±0.004 -5.8 0.000
vietnam_​by_​province_​since_​1996/​vietnam_​population_​by_​province_​2019.csv 0.663±0.007 0.628±0.007 -5.4 0.000
world_​by_​region_​wo_​antarctica/​world_​population_​by_​region_​wo_​antarctica.csv 8.015±0.505 7.342±0.037 -8.4 0.022
🐢 Slow-downs (0)

none

⚖️ No significant change (25)
map main pr Δ % p
algeria_​by_​wilaya_​since_​2019/​algeria_​population_​by_​wilaya_​2022.csv 0.706±0.002 0.678±0.004 -4.0 0.000
australia_​by_​state_​and_​territory_​since_​1942/​australia_​population_​by_​state_​and_​territory_​2021.csv 0.751±0.019 0.722±0.010 -3.8 0.012
austria_​by_​state_​since_​1945/​austria_​population_​by_​state_​2020.csv 0.225±0.002 0.217±0.003 -3.7 0.000
bahamas_​by_​district_​since_​1999/​bahamas_​population_​by_​district_​2010.csv 3.484±0.020 3.370±0.026 -3.3 0.000
belgium_​by_​region_​simplified_​since_​1995/​belgium_​population_​by_​region_​simplified_​2022.csv 0.072±0.004 0.070±0.004 -2.8 0.187
belgium_​by_​region_​since_​1995/​belgium_​population_​by_​region_​2022.csv 0.097±0.004 0.093±0.009 -3.7 0.277
brazil_​by_​state_​since_​1988/​brazil_​population_​by_​state_​2021.csv 0.621±0.010 0.593±0.006 -4.5 0.000
china_​by_​province_​with_​chinese_​taipei_​since_​1998/​china_​population_​by_​province_​2020.csv 0.761±0.004 0.730±0.006 -4.0 0.000
contiguous_​usa_​by_​county_​since_​2001/​usa_​population_​by_​county_​2021.csv 34.080±5.448 29.150±2.335 -14.5 0.082
croatia_​by_​county_​since_​1992/​croatia_​covid_​cases_​by_​county_​2022.csv 0.210±0.001 0.202±0.003 -3.5 0.000
croatia_​by_​county_​since_​1992/​croatia_​population_​by_​county_​2021.csv 0.209±0.004 0.206±0.017 -1.7 0.615
egypt_​by_​governorate_​since_​2009/​egypt_​population_​by_​governate_​2017.csv 0.776±0.005 0.748±0.003 -3.7 0.000
eu_​by_​country_​until_​2020/​eu_​population_​by_​country_​2021.csv 1.698±0.012 1.644±0.019 -3.2 0.000
eu_​by_​region_​until_​2020/​eu_​population_​by_​region_​2020.csv 5.077±0.040 4.961±0.088 -2.3 0.022
france_​by_​metropolitan_​region_​since_​2016/​france_​population_​by_​metropolitan_​region_​2008.csv 0.248±0.002 0.238±0.004 -4.0 0.000
indonesia_​by_​province_​since_​2022/​indonesia_​population_​by_​province_​2024.csv 0.355±0.003 0.339±0.001 -4.6 0.000
japan_​by_​prefecture_​since_​1888/​japan_​population_​by_​prefecture_​2020.csv 0.670±0.008 0.644±0.006 -3.8 0.000
malaysia_​by_​state_​since_​2001/​malaysia_​population_​by_​state_​2020.csv 0.345±0.002 0.329±0.004 -4.6 0.000
malaysia_​by_​state_​since_​2001/​malaysia_​population_​by_​state_​2020_​insetted.csv 0.304±0.002 0.290±0.002 -4.5 0.000
metropolitan_​france_​by_​departement_​since_​2015/​metropolitan_​france_​population_​by_​departement_​2022.csv 0.961±0.007 0.923±0.008 -3.9 0.000
singapore_​by_​planning_​area_​since_​1999/​singapore_​population_​by_​planning_​area_​2015.csv 2.213±0.010 2.170±0.038 -2.0 0.037
usa_​by_​state_​since_​1959/​usa_​population_​by_​state_​2020.csv 0.746±0.017 0.738±0.021 -1.1 0.494
usa_​by_​state_​since_​1959/​usa_​population_​by_​state_​2020_​insetted.csv 0.522±0.006 0.504±0.013 -3.6 0.013
world_​by_​country_​since_​2022/​world_​population_​by_​country_​2010.csv 6.466±0.163 5.705±0.820 -11.8 0.072
world_​by_​region/​world_​population_​by_​region.csv 5.831±0.483 5.364±0.040 -8.0 0.064

@nihalzp nihalzp changed the title Add CI build, tests for Linux/arm64 Add CI build, tests for Linux/arm64 and migrate to jsoncons csv-parser Oct 15, 2025
@nihalzp nihalzp merged commit aed99b3 into main Oct 15, 2025
36 checks passed
@nihalzp nihalzp deleted the macos-fix branch October 15, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation fault when running the released binary on linux/arm64

2 participants