contextual-decorator: fails for some cases

[rafaelss95]

Case 1: (It doesn't report failures for pipes) Fixed in #754.

@Pipe({
  name: 'app-test'
})
export class TestPipe {
  @Input() someVar: string; // should report a failure, currently it does not.
}

Case 2: (it doesn't report failures if ViewChild decorator is applied to a setter accessor)

@Injectable({ // doesn't work for @Pipe also
  providedIn: 'root'
})
export class TestService {
  @ViewChild(Pane)  // should report a failure, currently it does not.
  set pane(v: Pane) {
    console.log('v', v);
  }
}

---

Also, the @Attribute decorator is not handled at the moment. Is it intentional? @mgechev @wKoza

[wKoza]

@Attribute can only be used in a constructor. It's maybe the reason (which it's not a valid reason ;) ).
But, if we handle @Attribute, what about @Host, @Self, ... ?

So, I don't think it's intentional.

[wKoza]

@rafaelss95 , I've just seen that @Attribute is a bad practice here

[rafaelss95]

@rafaelss95 , I've just seen that @Attribute is a bad practice here

@wKoza Yep, it's supposed to be, however the rules are independent, right?

[wKoza]

I think we should still keep some consistency but I don't have the whole history of this rule.

[superdyzio]

Today I noticed weird behavior for @Pipe and @Injectable.
Example:

@Pipe({
  name: 'tableRow',
})
export class TableRowPipe implements PipeTransform {
    @Input() x; // not an error
}

and

@Pipe()
export class TableRowPipe implements PipeTransform {
    @Input() x; // error
}

Similar behavior for @Injectable() and @Injectable({...}). Codelyzer 5.0.1 and tslint 5.16.0.

EDIT: I just checked pull request mentioned above 😃