Skip to content

chore: setup prettier#566

Merged
mgechev merged 4 commits intomgechev:masterfrom
rafaelss95:prettier
Apr 25, 2018
Merged

chore: setup prettier#566
mgechev merged 4 commits intomgechev:masterfrom
rafaelss95:prettier

Conversation

@rafaelss95
Copy link
Collaborator

@rafaelss95 rafaelss95 commented Apr 21, 2018

This:

  • Removes conflicting tslint (stylistic) rules;
  • Adds a few devDependencies:
  • Formats all files using prettier;

See #557 (comment).

@rafaelss95
Copy link
Collaborator Author

rafaelss95 commented Apr 21, 2018

Travis is currently failing and I'm not sure what the correct fix would be, but it looks like the lint-staged needs node >= 6 and travis is currently using node 5 and I also noticed that it's using older versions of rxjs/zone.js.

@mgechev
Copy link
Owner

mgechev commented Apr 21, 2018

Would you also switch to node stable from 5?

@rafaelss95
Copy link
Collaborator Author

I've switched to the latest LTS and the error is different now:

/Users/travis/.travis/job_stages: line 166: shell_session_update: command not found

@wKoza
Copy link
Collaborator

wKoza commented Apr 22, 2018

@rafaelss95 , why did you add the devDependencies husky ? I don't see it used.

@rafaelss95
Copy link
Collaborator Author

rafaelss95 commented Apr 22, 2018

@wKoza husky is used to manage git hooks. In this case, it'll run what I've defined in lint-staged (format and lint fixes) and also will prevent commits if the tests aren't passing.

On other hand, I can remove it since the CI will fail anyway in a PR, for example. Let me know what's your decision.

@wKoza
Copy link
Collaborator

wKoza commented Apr 22, 2018

Ok, thanks @rafaelss95. I'm in favor of adding a hook for the lint. BTW, I was afraid of having a hook that launches TUs. (sometimes, We want to push a TU in failure in order to fix it later).

@mgechev mgechev merged commit 2184b91 into mgechev:master Apr 25, 2018
@rafaelss95 rafaelss95 deleted the prettier branch May 4, 2018 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants