fix: some rules not considering options correctly

[rafaelss95]

The following rules aren't behaving correctly at the moment:

• max-inline-declarations;
• no-input-prefix;
• prefer-inline-decorator;

The problem with these rules are that it's only considering the options from the second element (in position 1) of the array, which is totally incorrect.

---

Example for max-inline-declarations:

{
  "rules": {
    "max-inline-declarations": [true, { "template": 2 }]
  }
}

@Component({
  selector: 'app-root',
  template: `
    <div>
     something here
    </div>
  `,
  styleUrls: ['./app.component.css']
})
export class AppComponent {}

Expected behavior:
Failure.

Actual behavior:
No failure.

---

This fixes the wrong behavior and respective tests, with some refactor.

PS: The spec file of max-inline-declarations was wrongly named.

[rafaelss95]

@wKoza can you review?

[wKoza]

@rafaelss95 , we have an another problem with the rule max-inline-declarations in your example. This rule compute all the lines between ' ... '. Your use case, the rule count 5 lines but I think that 3 is the good value. So, we should exclude a first and the last line when it is empty lines.

[wKoza]

It's a shame to lost the value : template lines. It's a valuable value.

[rafaelss95]

No problem, I'll put it again.

[rafaelss95]

@wKoza Hmm, yes, I noticed this problem now. I've pushed the changes you requested.

---

Thinking more about it... should we exclude all empty lines from calculation or only the first and last? And what about comments? I'm asking because someone, for example, requested in palantir/tslint#3672 to max-file-line-count not count comment lines.

@Component({
  selector: 'app-root',
  template: `
    <div>
     something here
     <!-- a comment here -->
    </div>
  `,
  styleUrls: ['./app.component.css']
})
export class AppComponent {}

[wKoza]

The main reason for this rule is to increase readabilty of our components. All the HTML source code obscure the component's implementation, so, I think we can compute comments and the other empty lines.