fix(no-output-on-prefix): fix regular expression#674
Merged
mgechev merged 3 commits intomgechev:masterfrom Jun 24, 2018
loktionov129:patch-1
Merged
fix(no-output-on-prefix): fix regular expression#674mgechev merged 3 commits intomgechev:masterfrom loktionov129:patch-1
mgechev merged 3 commits intomgechev:masterfrom
loktionov129:patch-1
Conversation
this commit fixes incorrect behavior when memberName contains 'on' suffix in the word, for example selectionChanged.
```
/on((?![a-z])|(?=$))/.test('selectionChanged');
// true
/^on((?![a-z])|(?=$))/.test('selectionChanged');
// false
```
Collaborator
|
Good catch! Could you add a test containing a case like this you mentioned? |
rafaelss95
reviewed
Jun 24, 2018
test/noOutputOnPrefixRule.spec.ts
Outdated
| }); | ||
|
|
||
| describe('valid output property name', () => { | ||
| it("should succeed, when a output property containing 'on' suffix", () => { |
Collaborator
There was a problem hiding this comment.
a -> an. Also, you can put this test in the above describe.
rafaelss95
approved these changes
Jun 24, 2018
Collaborator
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit fixes incorrect behavior when memberName contains 'on' suffix in the word, for example selectionChanged.