fix: errors not being displayed in the correct files#700
Merged
mgechev merged 1 commit intomgechev:masterfrom Aug 13, 2018
rafaelss95:fix-regression-deprecation
Merged
fix: errors not being displayed in the correct files#700mgechev merged 1 commit intomgechev:masterfrom rafaelss95:fix-regression-deprecation
mgechev merged 1 commit intomgechev:masterfrom
rafaelss95:fix-regression-deprecation
Conversation
|
Thank you @rafaelss95 for fixing this. @mgechev, could you please publish a new release ASAP with this fix merged in? The bug is actually mangling code, so getting a new release out quickly will help prevent other developers from the ensuing headaches of encountering this bug. Thanks! |
|
Glad to see this will be in the next release. I updated my dependencies today to find the linter mangling TS files as others mentioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #692 #699.
It was a regression caused by PR #587. I'm not sure how we can add tests to prevent errors like this from popping up.