Skip to content

fix: assertFailure catch exception throw by assert (#703)#704

Merged
mgechev merged 1 commit intomgechev:masterfrom
someblue:master
Aug 24, 2018
Merged

fix: assertFailure catch exception throw by assert (#703)#704
mgechev merged 1 commit intomgechev:masterfrom
someblue:master

Conversation

@someblue
Copy link
Contributor

Fix #703.

I think try catch statement inside assertFailure() is unnecessary. Because:

  1. If exception happens in lint(), this test case should be treated as a fail test. This exception should be catch by Chai.
  2. It's unnecessary to print exception stack. Chai will print it in a better place and format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants