feat(rule): label accessibility - should have associated control#739
Merged
mgechev merged 2 commits intomgechev:masterfrom Feb 11, 2019
mohammedzamakhan:a11y-for
Merged
feat(rule): label accessibility - should have associated control#739mgechev merged 2 commits intomgechev:masterfrom mohammedzamakhan:a11y-for
mgechev merged 2 commits intomgechev:masterfrom
mohammedzamakhan:a11y-for
Conversation
mgechev
reviewed
Feb 7, 2019
mgechev
reviewed
Feb 7, 2019
mgechev
reviewed
Feb 7, 2019
Owner
mgechev
left a comment
mgechev
left a comment
There was a problem hiding this comment.
Excellent job! Left two questions.
Collaborator
|
It's a nice rule... however I have one question: Doesn't it need to follow the current process of voting before we can merge? |
rafaelss95
reviewed
Feb 8, 2019
rafaelss95
reviewed
Feb 8, 2019
Owner
|
@rafaelss95 we have the voting only to prioritize feature requests. If someone develops a rule which would be useful for community, we can merge without voting! |
rafaelss95
reviewed
Feb 8, 2019
mgechev
reviewed
Feb 8, 2019
Owner
mgechev
left a comment
mgechev
left a comment
There was a problem hiding this comment.
Let's drop the depth check and merge! Thanks for the great rule! :)
Contributor
Author
|
@mgechev Done 👍 |
mgechev
approved these changes
Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.