feat(rule): use valid aria rules#746
Merged
mgechev merged 2 commits intomgechev:masterfrom Feb 12, 2019
mohammedzamakhan:aria-props
Merged
feat(rule): use valid aria rules#746mgechev merged 2 commits intomgechev:masterfrom mohammedzamakhan:aria-props
mgechev merged 2 commits intomgechev:masterfrom
mohammedzamakhan:aria-props
Conversation
mgechev
reviewed
Feb 9, 2019
mgechev
approved these changes
Feb 9, 2019
Owner
mgechev
left a comment
mgechev
left a comment
There was a problem hiding this comment.
Left a minor comment. I like the string distance suggestions!
wKoza
requested changes
Feb 10, 2019
mgechev
reviewed
Feb 11, 2019
mgechev
approved these changes
Feb 11, 2019
wKoza
approved these changes
Feb 12, 2019
mgechev
approved these changes
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.