feat(rule): autofocus attribute should not be used#749
Merged
mgechev merged 1 commit intomgechev:masterfrom Feb 11, 2019
mohammedzamakhan:no-autofocus
Merged
feat(rule): autofocus attribute should not be used#749mgechev merged 1 commit intomgechev:masterfrom mohammedzamakhan:no-autofocus
mgechev merged 1 commit intomgechev:masterfrom
mohammedzamakhan:no-autofocus
Conversation
mgechev
reviewed
Feb 9, 2019
mgechev
reviewed
Feb 9, 2019
mgechev
reviewed
Feb 9, 2019
mgechev
reviewed
Feb 9, 2019
mgechev
reviewed
Feb 9, 2019
Owner
mgechev
left a comment
mgechev
left a comment
There was a problem hiding this comment.
Left few minor comments. Would you share details about autofocus considered as a bad practice?
Contributor
Author
|
@mgechev you can find the warning here https://w3c.github.io/html/sec-forms.html#autofocusing-a-form-control-the-autofocus-attribute |
mgechev
approved these changes
Feb 11, 2019
|
Seems like W3C has removed the warning about autofocus now. I don't see anything referencing autofocus in the July 18, 2019 version of the document. I would like to review the discussion if I could find it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.