feat(rule): no distracting elements should be used#760
Merged
mgechev merged 1 commit intomgechev:masterfrom Feb 15, 2019
mohammedzamakhan:no-distracting-elements
Merged
feat(rule): no distracting elements should be used#760mgechev merged 1 commit intomgechev:masterfrom mohammedzamakhan:no-distracting-elements
mgechev merged 1 commit intomgechev:masterfrom
mohammedzamakhan:no-distracting-elements
Conversation
mgechev
reviewed
Feb 13, 2019
| typescriptOnly: true | ||
| }; | ||
|
|
||
| static readonly FAILURE_STRING = 'Avoid using <%s> elements as they create visual accessibility issues.'; |
mgechev
approved these changes
Feb 13, 2019
wKoza
reviewed
Feb 14, 2019
| } | ||
|
|
||
| private validateElement(el: ElementAst): void { | ||
| if (el.name === 'marquee' || el.name === 'blink') { |
Collaborator
There was a problem hiding this comment.
When I see this link, I'm not sure that we have to test 'blink'.
Contributor
Author
There was a problem hiding this comment.
I think its fine, since all the accessibility checkers and linters check for it. Sometimes developers use code generated or from old references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.