refactor(rule): rename/clean up 'no-attribute-parameter-decorator'#781
Merged
mgechev merged 1 commit intomgechev:masterfrom Mar 6, 2019
rafaelss95:refactor/no-attribute-decorator
Merged
refactor(rule): rename/clean up 'no-attribute-parameter-decorator'#781mgechev merged 1 commit intomgechev:masterfrom rafaelss95:refactor/no-attribute-decorator
mgechev merged 1 commit intomgechev:masterfrom
rafaelss95:refactor/no-attribute-decorator
Conversation
rafaelss95
commented
Mar 2, 2019
| typescriptOnly: true | ||
| }; | ||
|
|
||
| static readonly FAILURE_STRING = '@Attribute is considered bad practice. Use @Input instead.'; |
Collaborator
Author
There was a problem hiding this comment.
Not sure about this message...
Collaborator
Author
There was a problem hiding this comment.
If there's any place in the Angular Style Guide that says it's a bad practice to use @Attribute we should link it here, otherwise better rephrase this (and also the rationale).
Collaborator
Author
|
Ping @mgechev |
mgechev
approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #754.