fix(rule): 'prefer-inline-decorator' limiting the number of options#787
Merged
mgechev merged 2 commits intomgechev:masterfrom Mar 8, 2019
rafaelss95:refactor/prefer-inline-decorator
Merged
fix(rule): 'prefer-inline-decorator' limiting the number of options#787mgechev merged 2 commits intomgechev:masterfrom rafaelss95:refactor/prefer-inline-decorator
mgechev merged 2 commits intomgechev:masterfrom
rafaelss95:refactor/prefer-inline-decorator
Conversation
Collaborator
Author
|
Look at this spec: codelyzer/test/preferInlineDecoratorRule.spec.ts Lines 31 to 65 in 049be66 When I implemented this rule, I had to use ... Btw, the same happens with
... you'll see the failure being reported (in the rule), but in the Any thoughts? |
Owner
|
@rafaelss95 not sure where this may come from, I haven't hit this issue but sounds like a problem in |
mgechev
approved these changes
Mar 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…assed as options
Currently, the rule allows only eight options/decorators to be passed.