feat(rule): add use-injectable-provided-in#814
Merged
mgechev merged 3 commits intomgechev:masterfrom May 1, 2019
mohammedzamakhan:provided-in
Merged
feat(rule): add use-injectable-provided-in#814mgechev merged 3 commits intomgechev:masterfrom mohammedzamakhan:provided-in
mgechev merged 3 commits intomgechev:masterfrom
mohammedzamakhan:provided-in
Conversation
rafaelss95
requested changes
Apr 23, 2019
Collaborator
|
@mohammedzamakhan I've left some minor comments, please have a look. |
Collaborator
|
@mohammedzamakhan Can you just change the commit message to |
rafaelss95
changed the title
Contributor
Author
|
@rafaelss95 done 👍 |
Owner
|
I'll restart travis and merge when the build passes. |
Collaborator
|
I investigated the reason behind the build failure and it seems that the problem is with The fix should have come in sass/node-sass@23c8659, but apparently it hasn't yet been published in npm. Edit: They just published the v4.12.0 into npm. I've submitted the fix in #818. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#558