save a little on write() - moving conditions into intialization phase#17
Open
apankov wants to merge 1 commit intomhart:masterfrom
Open
save a little on write() - moving conditions into intialization phase#17apankov wants to merge 1 commit intomhart:masterfrom
apankov wants to merge 1 commit intomhart:masterfrom
Conversation
Owner
|
Hmmm, I struggle to think of a scenario where this code path would make any real difference to performance considering this operation will be I/O bound. Have you measured performance here – or was this a pre-emptive change? |
Author
|
That's rather pre-emptive strategy. I foresee my case where I'd like to collect lots of data per shot. I had very preliminary tests on big runs and got empirical understanding of performance penalties. I understand that's not the way how to measure performance, but anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Michael, what do you think about micro-optimization? Thanks