Skip to content

save a little on write() - moving conditions into intialization phase#17

Open
apankov wants to merge 1 commit intomhart:masterfrom
apankov:master
Open

save a little on write() - moving conditions into intialization phase#17
apankov wants to merge 1 commit intomhart:masterfrom
apankov:master

Conversation

@apankov
Copy link

@apankov apankov commented Jul 4, 2017

Hey Michael, what do you think about micro-optimization? Thanks

@mhart
Copy link
Owner

mhart commented Jul 4, 2017

Hmmm, I struggle to think of a scenario where this code path would make any real difference to performance considering this operation will be I/O bound.

Have you measured performance here – or was this a pre-emptive change?

@apankov
Copy link
Author

apankov commented Jul 6, 2017

That's rather pre-emptive strategy. I foresee my case where I'd like to collect lots of data per shot. I had very preliminary tests on big runs and got empirical understanding of performance penalties. I understand that's not the way how to measure performance, but anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants