Skip to content

Exclude Module Config Added#167

Closed
luigifcruz wants to merge 4 commits intomherrmann:masterfrom
luigifcruz:master
Closed

Exclude Module Config Added#167
luigifcruz wants to merge 4 commits intomherrmann:masterfrom
luigifcruz:master

Conversation

@luigifcruz
Copy link
Copy Markdown
Contributor

@luigifcruz luigifcruz commented Jan 11, 2020

Add the ability to list modules to be excluded when freezing with PyInstaller. #90

@claassistantio
Copy link
Copy Markdown

claassistantio commented Jan 11, 2020

CLA assistant check
All committers have signed the CLA.

causes error on pthread
@mherrmann
Copy link
Copy Markdown
Owner

Thank you for the PR. I think I would enable this via a new extra_pyinstaller_args setting. See here. I don't have time to work on this right now, but hopefully again in February.

@luigifcruz
Copy link
Copy Markdown
Contributor Author

@mherrmann I reverted this PR to the initial state and implemented the specified changes for passing arbitrary PyInstaller arguments. Tested with the latest version of PyInstaller.

@mherrmann
Copy link
Copy Markdown
Owner

Thanks. The changes look good to me but I need to update the documentation as well and release a new version. I'll look at this in February.

@mherrmann
Copy link
Copy Markdown
Owner

I now released this in fbs 0.8.9. Thanks!

@mherrmann mherrmann closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants