Allow for CURL options to be set, and expose errors#26
Open
oligriffiths wants to merge 13 commits intomichaelbutler:masterfrom
Open
Allow for CURL options to be set, and expose errors#26oligriffiths wants to merge 13 commits intomichaelbutler:masterfrom
oligriffiths wants to merge 13 commits intomichaelbutler:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Michael, hope you're well.
Here's a patch to allow setting of CURL options and exposing curl errors.
We are investigating some errors with this library hanging indefinitely. I believe this to be due to no CURL timeouts being set, but not totally sure.
This patch will allow us to set whatever CURL options we want, including
CURLOPT_CONNECTTIMEOUTandCURLOPT_TIMEOUT.I also noticed that there doesn't appear to be and handling for if curl responds with an error, but I will leave that update to a future patch as this change will unblock me now and I am unsure how you might like to handle curl errors.