Mf/better ci

[michaelfeil]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on adjusting the project's internal naming convention within its Python packaging configuration. The modification of the project name in pyproject.toml is a targeted change aimed at streamlining or improving the continuous integration pipeline, potentially to avoid naming conflicts or enable specific build strategies.

Highlights

• Project Name Update: The project name in python/pyproject.toml has been updated from "fastokens" to "fastokens-b10". This change is likely intended to facilitate better continuous integration processes, possibly by providing a unique identifier for builds or environments.

Ignored Files

• Ignored by pattern: .github/workflows/** (2)
  • .github/workflows/build-maturin.yml
  • .github/workflows/build-release-fastokens.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request changes the package name in pyproject.toml by adding a -b10 suffix. Given the pull request title, this is likely for CI purposes. However, hardcoding a build-specific identifier in the project configuration is not a maintainable practice. My review includes a suggestion to revert this change and instead handle package name modifications for test builds dynamically within the CI pipeline to improve maintainability.

[gemini-code-assist]

Hardcoding a build-specific suffix like -b10 in the project name is not ideal for maintainability, as it would require a code change for every new build. This can make the CI process brittle and hard to manage.

A better approach for publishing test packages from CI is to modify the package name dynamically within the CI pipeline before the build and publish steps. This avoids committing temporary or build-specific names to version control.

Suggested change

	name = "fastokens-b10"
	name = "fastokens"