Open
Conversation
Derstilon
added
bug
Derstilon
commented
May 25, 2021
# Conflicts: # package-lock.json # package.json # src/@types/types.d.ts # src/lecturer/components/createSessionView/CreateSessionView.tsx # src/lecturer/components/quizStatsView/QuizStatsView.tsx # src/lecturer/components/sendQuizView/SendQuizView.tsx # src/lecturer/components/shareSessionView/ShareSessionView.tsx # src/lecturer/services/StoreService.tsx # src/lecturer/util/mockData.ts
michal367
approved these changes
Jun 9, 2021
…e/better-animation-student-reaction # Conflicts: # src/@types/types.d.ts # src/lecturer/components/quizStatsView/QuizStatsView.tsx # src/lecturer/components/sendQuizView/SendQuizView.tsx
…e/better-animation-student-reaction # Conflicts: # src/lecturer/components/app/App.tsx
ostatni5
approved these changes
Jun 9, 2021
# Conflicts: # src/lecturer/components/quizStatsView/QuizStatsView.tsx # src/lecturer/components/sendQuizView/SendQuizView.tsx # src/lecturer/services/StoreService.tsx
Derstilon
force-pushed
the
add-current-quiz-position-in-stats
branch
from
96c0586 to
bc19088
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature doesn't quite work because our store is the madness of references. Changing quiz in send quiz view changes it also for already send quizzes. We have to fix it once we add IDs to the objects.