Standardize deduplication API and error-handling contract#511
Open
sebastienviale wants to merge 4 commits intomichelin:mainfrom
Open
Standardize deduplication API and error-handling contract#511sebastienviale wants to merge 4 commits intomichelin:mainfrom
sebastienviale wants to merge 4 commits intomichelin:mainfrom
Conversation
sebastienviale
force-pushed
the
feature/add_dedup_without_processing_result
branch
from
451bc0e to
f4dd2f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves and standardizes the deduplication API documentation and usage patterns in DeduplicationUtils.
Key changes
Clarified and corrected documentation for all deduplication methods.
Explicitly distinguishes between:
*WithErrors methods returning KStream<String, ProcessingResult<V, V>>
non-error methods returning KStream<String, V>
Updated all usage examples to correctly wrap *WithErrors methods with TopologyErrorHandler.catchErrors(...).
Added missing examples for both variants (with and without error handling) across:
deduplication by key
key + value
predicate-based deduplication
header-based deduplication
Fixed inconsistencies in method usage and improved clarity of expected behavior.
Removed ambiguity around when and how to use error-handling wrappers.