Skip to content

Conversation

@kneep
Copy link

@kneep kneep commented Oct 8, 2021

No description provided.

@pablogs9
Copy link
Member

pablogs9 commented Oct 8, 2021

Add documentation to README.md

@kneep
Copy link
Author

kneep commented Oct 8, 2021

Add documentation to README.md

Just updated the PR.

@kneep
Copy link
Author

kneep commented Oct 11, 2021

Add documentation to README.md

@pablogs9 Hi Pablo. Could please review the updated patch?

README.md Outdated
- a set of **[micro-ROS utils for STM32CubeMX and STM32CubeIDE](https://github.com/micro-ROS/micro_ros_stm32cubemx_utils)**: this package enables the integration of micro-ROS in STM32CubeMX and STM32CubeIDE.
- a precompiled set of **[Arduino IDE libraries](https://github.com/micro-ROS/micro_ros_arduino)**: this package enables the integration of micro-ROS in the Arduino IDE for some hardware platforms.
- a precompiled set of **[Raspberry Pi Pico SDK libraries](https://github.com/micro-ROS/micro_ros_raspberrypi_pico_sdk)**: this package enables the integration of micro-ROS in the Raspberry Pi Pico SDK.
- **[Latest Android NDK](https://developer.android.com/ndk/downloads)**: this package is used to build the MicroROS for Android.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **[Latest Android NDK](https://developer.android.com/ndk/downloads)**: this package is used to build the MicroROS for Android.

This section is used for other micro-ROS compilation utils.

Maybe you can add this link to the dependencies section, or add a download step on the create.sh script like here: raspbian create.sh

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Acuadros95 I revised the patch, moving it to the dependencies section.

Signed-off-by: Joel Cao <joel.cao@oppo.com>
@Acuadros95 Acuadros95 merged commit 967e7ad into micro-ROS:galactic Oct 11, 2021
@pablogs9
Copy link
Member

@mergify backport main

mergify bot pushed a commit that referenced this pull request Oct 19, 2021
Signed-off-by: Joel Cao <joel.cao@oppo.com>

Co-authored-by: Joel Cao <joel.cao@oppo.com>
(cherry picked from commit 967e7ad)
@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

backport main

✅ Backports have been created

Hey, I reacted but my real name is @Mergifyio

pablogs9 pushed a commit that referenced this pull request Oct 19, 2021
Signed-off-by: Joel Cao <joel.cao@oppo.com>

Co-authored-by: Joel Cao <joel.cao@oppo.com>
(cherry picked from commit 967e7ad)

Co-authored-by: kneep <alvin.cao@gmail.com>
Acuadros95 pushed a commit that referenced this pull request Nov 19, 2021
Signed-off-by: Joel Cao <joel.cao@oppo.com>

Co-authored-by: Joel Cao <joel.cao@oppo.com>
(cherry picked from commit 967e7ad)

Co-authored-by: kneep <alvin.cao@gmail.com>
Acuadros95 added a commit that referenced this pull request Nov 19, 2021
* Update README.md (#386) (#388)

(cherry picked from commit a4c138e)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>

* Remove references to log4cxx (#389)

* Add android support config (#396) (#405)

Signed-off-by: Joel Cao <joel.cao@oppo.com>

Co-authored-by: Joel Cao <joel.cao@oppo.com>
(cherry picked from commit 967e7ad)

Co-authored-by: kneep <alvin.cao@gmail.com>

* Temporal fix for cmake update

* Fix rebase

* Add fix to regular CI

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Co-authored-by: kneep <alvin.cao@gmail.com>
mergify bot added a commit that referenced this pull request Nov 19, 2021
* Update README.md (#386) (#388)

(cherry picked from commit a4c138e)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>

* Remove references to log4cxx (#389)

* Add android support config (#396) (#405)

Signed-off-by: Joel Cao <joel.cao@oppo.com>

Co-authored-by: Joel Cao <joel.cao@oppo.com>
(cherry picked from commit 967e7ad)

Co-authored-by: kneep <alvin.cao@gmail.com>

* Temporal fix for cmake update

* Fix rebase

* Add fix to regular CI

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Co-authored-by: kneep <alvin.cao@gmail.com>
(cherry picked from commit fa579fd)
Acuadros95 added a commit that referenced this pull request Nov 19, 2021
* Update README.md (#386) (#388)

(cherry picked from commit a4c138e)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>

* Remove references to log4cxx (#389)

* Add android support config (#396) (#405)

Signed-off-by: Joel Cao <joel.cao@oppo.com>

Co-authored-by: Joel Cao <joel.cao@oppo.com>
(cherry picked from commit 967e7ad)

Co-authored-by: kneep <alvin.cao@gmail.com>

* Temporal fix for cmake update

* Fix rebase

* Add fix to regular CI

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Co-authored-by: kneep <alvin.cao@gmail.com>
(cherry picked from commit fa579fd)

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants