Skip to content

Don't link dl library when not needed #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogs9 merged 1 commit into from
Jul 17, 2023
Merged

Don't link dl library when not needed #28

pablogs9 merged 1 commit into from
Jul 17, 2023

Conversation

@bjsowa
Copy link

@bjsowa bjsowa commented Jul 16, 2023

No description provided.

@pablogs9
Copy link
Member

pablogs9 commented Jul 17, 2023

Are you building micro-ROS with RCUTILS_NO_FILESYSTEM disabled?

@bjsowa
Copy link
Author

bjsowa commented Jul 17, 2023

I'm building with RCUTILS_NO_FILESYSTEM option enabled.

@pablogs9
Copy link
Member

pablogs9 commented Jul 17, 2023

In that case you are not linking target_link_libraries(${PROJECT_NAME} ${CMAKE_DL_LIBS})

Why do you need this change?

@bjsowa
Copy link
Author

bjsowa commented Jul 17, 2023

That's exactly why I need it, so it does not get linked.

@pablogs9
Copy link
Member

pablogs9 commented Jul 17, 2023

Understood

@pablogs9
Copy link
Member

pablogs9 commented Jul 17, 2023

@mergify backport iron humble

@mergify
Copy link

mergify bot commented Jul 17, 2023 •
edited
Loading

backport iron humble

✅ Backports have been created

Details

@pablogs9 pablogs9 merged commit 55de2e1 into micro-ROS:rolling Jul 17, 2023
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
@bjsowa @mergify
Don't link dl library when not needed (#28)
6c11eda 
(cherry picked from commit 55de2e1)
@mergify mergify bot mentioned this pull request Jul 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
@bjsowa @mergify
Don't link dl library when not needed (#28)
735bac7 
(cherry picked from commit 55de2e1)
@mergify mergify bot mentioned this pull request Jul 17, 2023
Merged
pablogs9 pushed a commit that referenced this pull request Jul 17, 2023
@mergify @bjsowa
Don't link dl library when not needed (#28) (#30)
91e657e 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
pablogs9 pushed a commit that referenced this pull request Jul 17, 2023
@mergify @bjsowa
Don't link dl library when not needed (#28) (#29)
96c778b 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
pablogs9 pushed a commit that referenced this pull request Sep 4, 2023
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
552cb11
pablogs9 pushed a commit that referenced this pull request Sep 8, 2023
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
180bb76
pablogs9 pushed a commit that referenced this pull request Sep 18, 2023
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
ce0e472
pablogs9 pushed a commit that referenced this pull request Oct 5, 2023
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
6d5476a
pablogs9 pushed a commit that referenced this pull request Nov 6, 2023
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
ef4e16b
pablogs9 pushed a commit that referenced this pull request Nov 7, 2023
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
2b94079
pablogs9 pushed a commit that referenced this pull request Nov 10, 2023
@mergify @bjsowa @pablogs9
Don't link dl library when not needed (#28) (#29)
4806baa 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
pablogs9 pushed a commit that referenced this pull request Nov 10, 2023
@mergify @bjsowa @pablogs9
Don't link dl library when not needed (#28) (#30)
6c17b77 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
pablogs9 pushed a commit that referenced this pull request Nov 10, 2023
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
02a3dcb
pablogs9 pushed a commit that referenced this pull request Nov 14, 2023
@mergify @bjsowa @pablogs9
Don't link dl library when not needed (#28) (#30)
7c3e3d1 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
pablogs9 pushed a commit that referenced this pull request Nov 17, 2023
@mergify @bjsowa @pablogs9
Don't link dl library when not needed (#28) (#29)
056c89c 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
pablogs9 pushed a commit that referenced this pull request Nov 28, 2023
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
408394c
pablogs9 pushed a commit that referenced this pull request Jan 5, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
5b507b7
pablogs9 pushed a commit that referenced this pull request Jan 24, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
1458d72
pablogs9 pushed a commit that referenced this pull request Apr 29, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
547bf26
pablogs9 pushed a commit that referenced this pull request Apr 30, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
39bd1ea
pablogs9 pushed a commit that referenced this pull request May 16, 2024
@mergify @bjsowa @pablogs9
Don't link dl library when not needed (#28) (#30)
3ae278c 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
pablogs9 pushed a commit that referenced this pull request Jun 5, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
006e859
pablogs9 pushed a commit that referenced this pull request Jun 6, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
8fa229c
pablogs9 pushed a commit that referenced this pull request Jun 18, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
6b457bd
pablogs9 pushed a commit that referenced this pull request Jul 9, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
2c141ac
pablogs9 pushed a commit that referenced this pull request Jul 30, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
9e6379c
pablogs9 pushed a commit that referenced this pull request Sep 17, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
9f05850
pablogs9 pushed a commit that referenced this pull request Sep 18, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
3ee0173
pablogs9 pushed a commit that referenced this pull request Oct 4, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
604c19d
pablogs9 pushed a commit that referenced this pull request Nov 27, 2024
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
2da28f7
pablogs9 pushed a commit that referenced this pull request Jan 7, 2025
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
ac19200
pablogs9 pushed a commit that referenced this pull request Feb 3, 2025
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
5d2c5ce
pablogs9 pushed a commit that referenced this pull request Mar 24, 2025
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
a0a103b
pablogs9 pushed a commit that referenced this pull request Mar 27, 2025
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
f3c651b
pablogs9 pushed a commit that referenced this pull request Mar 31, 2025
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
a338967
pablogs9 pushed a commit that referenced this pull request Apr 2, 2025
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
193d5b0
pablogs9 pushed a commit that referenced this pull request Apr 3, 2025
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
fa7a213
4ntn pushed a commit that referenced this pull request May 5, 2025
@bjsowa @4ntn
Don't link dl library when not needed (#28)
bc317e3
4ntn pushed a commit that referenced this pull request May 5, 2025
@bjsowa @4ntn
Don't link dl library when not needed (#28)
086e1c8
pablogs9 pushed a commit that referenced this pull request May 16, 2025
@bjsowa @pablogs9
Don't link dl library when not needed (#28)
65be471
4ntn pushed a commit that referenced this pull request Jun 2, 2025
@bjsowa @4ntn
Don't link dl library when not needed (#28)
29cee99
4ntn pushed a commit that referenced this pull request Jul 10, 2025
@bjsowa @4ntn
Don't link dl library when not needed (#28)
23ff466
4ntn pushed a commit that referenced this pull request Jul 15, 2025
@bjsowa @4ntn
Don't link dl library when not needed (#28)
9b8fa05
4ntn pushed a commit that referenced this pull request Aug 19, 2025
@mergify @bjsowa @4ntn
Don't link dl library when not needed (#28) (#30)
d0b4783 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
4ntn pushed a commit that referenced this pull request Sep 4, 2025
@mergify @bjsowa @4ntn
Don't link dl library when not needed (#28) (#30)
aaddd3e 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
Carlosespicur pushed a commit that referenced this pull request Sep 24, 2025
@mergify @bjsowa @Carlosespicur
Don't link dl library when not needed (#28) (#30)
77b32f0 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
Carlosespicur pushed a commit that referenced this pull request Sep 24, 2025
@mergify @bjsowa @Carlosespicur
Don't link dl library when not needed (#28) (#30)
c9885e9 
(cherry picked from commit 55de2e1)

Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
Carlosespicur pushed a commit that referenced this pull request Sep 24, 2025
@bjsowa @Carlosespicur
Don't link dl library when not needed (#28)
12b1022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bjsowa @pablogs9