Git diff gutter does not work correctly for files with windows line endings (CRLF)

[cs96and]

Description of the problem or steps to reproduce

When opening a git versioned file containing windows line endings (CRLF), the git diff gutter shows all lines as modified. This happens with the native windows binary, and the linux binary via WSL.

Specifications

Version: 2.0.1
Commit hash: 7c71995
Compiled on February 12, 2020
OS: Windows 10 (Version 1903)
Terminal: Cmd / Windows Terminal / Conemu

[p-e-w]

It looks like git show prints the file using LF line endings on your system despite the file in the working directory using CRLF. Can you confirm this by running git show HEAD:yourfile > output and then opening output to see what line endings it uses?

If output indeed uses LF, that is the problem. The solution might depend on your particular setup. A web search brings up hundreds of links explaining the various configuration options that control how Git handles line endings. The diff plugin needs to get Git to print the file using the same line endings as the working directory version.

It is tempting to handle this in the diff gutter code directly and just normalize line endings, but of course changing CRLF to LF and vice versa is a legitimate change that we do want to display when it happens so I don't think that would be the correct approach.