Skip to content

Fix two typos#499

Closed
HazenBabcock wants to merge 2 commits intomicro-manager:mainfrom
HazenBabcock:fix/typos
Closed

Fix two typos#499
HazenBabcock wants to merge 2 commits intomicro-manager:mainfrom
HazenBabcock:fix/typos

Conversation

@HazenBabcock
Copy link
Copy Markdown
Contributor

This replaces PrepareSequenceAcqusition with PrepareSequenceAcquisition and g_Keyword_Meatdata_Exposure with g_Keyword_Metadata_Exposure. It touches a lot of files because the first typo is present in most of the camera device adapters.

@tlambert03
Copy link
Copy Markdown
Contributor

Hey @HazenBabcock 👋, this is a duplicate of #453 ... see discussion there for hesitation on merge

@tlambert03
Copy link
Copy Markdown
Contributor

i think i missed Meatdata 😂

@HazenBabcock
Copy link
Copy Markdown
Contributor Author

Yes it is, apologies for that.. I should have checked the open pull requests first..

@marktsuchida
Copy link
Copy Markdown
Member

No problem, we appreciate this!

I think the Meatdata will be better to fix by keeping the old name (deprecated) for now, so as not to break things that depend on MMCore (including pymmcore), which exposes it in its API.

@HazenBabcock
Copy link
Copy Markdown
Contributor Author

HazenBabcock commented Oct 9, 2024

I could make another pull request where Meatdata_Exposure and Metadata_Exposure are both set? Then once Meatdata_Exposure is fixed in the dependencies it could be removed?

@marktsuchida
Copy link
Copy Markdown
Member

@HazenBabcock Yes, that would be perfect.

@HazenBabcock
Copy link
Copy Markdown
Contributor Author

Closed, see #503.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants