Miscellaneous cleanup for CCameraBase#753
Merged
marktsuchida merged 3 commits intomicro-manager:mainfrom Sep 25, 2025
Merged
Conversation
The base interface class MM::Camera already has an empty virtual destructor.
Use `this->` instead to access base class template members. However, had to keep 2 `using` declarations that make protected members of CDeviceBase public in CCameraBase, because a number of cameras depend on that.
C++ always calls a base class constructor, and there is no need to make an explicit call when using the default constructor of the base class. The fact that these show up in cameras, stages, and XY stages (but not other device types) suggests all this is the result of copy-paste. Since I recently removed a bunch of these (for cameras that needed to switch from CCameraBase to CLegacyCameraBase), I'm taking the opportunity to eradicate them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some followup to #590. See commits for details.
The removal of 'using' declarations needs confirmation: