fix: move stepTimeoutDuration to work as expected #94
Open
SLopez96 wants to merge 1 commit into
Open
Conversation
… to use it and update serialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During implementation of the Flutter BlinkID package, I noticed that the stepTimeoutDuration parameter had no effect on the actual timeout behavior. After debugging the Kotlin source files, I discovered that the timeout value was being incorrectly passed to BlinkIdSessionSettings instead of BlinkIdScanningUxSettings where it's actually used.
Solution
Moved stepTimeoutDuration from BlinkIdSessionSettings to BlinkIdScanningUxSettings in the Dart layer
Updated the automatically generated file
Testing
✅ Android: Verified working in my Flutter application
⚠️ iOS: Untested (no access to iOS development environment)
This change ensures the timeout parameter works as expected across platforms. Would appreciate if someone could verify the iOS implementation.