Fix Wither builder type resolution for nested records fix #366 #367
+74
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
araysse
changed the title
|
Collaborator
|
Please add a test that is reproducing this problem |
Collaborator
|
Why did you add JVM_17? |
sdelamo
requested changes
Dec 30, 2025
Contributor
sdelamo
left a comment
sdelamo
left a comment
There was a problem hiding this comment.
The pull request misses tests. Is there an issue this PR aims to fix?
sdelamo
requested changes
Dec 30, 2025
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
Author
i just need to make the build pass because i was have |
# Conflicts: # sourcegen-generator-kotlin/build.gradle.kts # test-suite-kotlin/build.gradle.kts
sdelamo
reviewed
Jan 2, 2026
...src/test/groovy/io/micronaut/sourcegen/generator/visitors/WitherAnnotationVisitorSpec.groovy
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
When using @wither and @builder annotations together on nested records (records defined inside a class), the generated wither interface incorrectly references the builder class name, causing compilation errors.
Approach
Derive the builder’s package from the binary name (the string with $ for inner classes), not the canonical name.
Compute the package as the substring of recordType.getName() up to the last '.'.
Build the builder simple name using the binary part if the record is inner:
Compose the final FQN as:
Preserve generics by using TypeDef.parameterized when the record type is parameterized.
Verification
Closes: #366