-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Problem
The orchestrator dispatches the quality gate as soon as it sees CI green + 0 open threads. But Copilot review may not have completed yet — it runs asynchronously after CI. This means:
- Quality gate evaluates and approves the PR
- Copilot review finishes and adds new comments
- The APPROVE review is now stale — it was based on pre-review state
- Auto-merge may proceed despite unresolved threads (mitigated by
required_conversation_resolution: truein branch protection, but the stale approval persists)
Example
PR #172: quality gate dispatched at 07:23 while Copilot was still reviewing. QG approved, then Copilot posted a new comment at 07:25. The approval was based on stale state.
Impact
- Wasted quality gate runs (approves then new comments appear)
- Stale APPROVE reviews persist because
dismiss_stale_reviews: false - Could lead to merges with unaddressed review comments if branch protection is ever relaxed
Fix options
- Orchestrator checks for Copilot review before dispatching QG — verify
copilot-pull-request-reviewerhas submitted a review on the latest commit - Quality gate agent checks for pending reviews — look at whether Copilot review is complete before evaluating
- Dismiss stale reviews on new pushes — set
dismiss_stale_reviews: trueso responder pushes invalidate the QG approval (but this affects all reviews, not just QG)
Related
- Quality gate never fires on clean PRs — orchestrator missing happy path #168 (quality gate dispatch)
- bug: orchestrator dispatches responder twice from duplicate triggers #164 (duplicate triggers)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working