-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Problem
The review-responder agent is instructed to run CI checks before pushing code (step 5: uv sync && uv run ruff check --fix . && ...), but astral.sh — the domain where uv and ruff binaries are hosted — is blocked by the gh-aw sandbox firewall.
This means the agent cannot run lint checks before pushing. When the agent writes code that violates ruff rules (e.g., E741 ambiguous variable name l), it pushes broken code and CI fails on the PR.
What happened
- Run 23351459250 (PR fix: populate active_* fields for pure active sessions (#154) #177, 2026-03-20 16:06 UTC): The responder successfully addressed 4 review comments using our new pre-fetch pattern, but pushed code containing
next(l for l in lines ...)which violates ruff E741. - The agent tried to run
/usr/bin/python3 --versionand got "Permission denied" — it could not execute any Python tooling inside the sandbox. - The PR body even warns:
⚠️ Firewall blocked 1 domain: astral.sh - CI (
uv run ruff check .) failed with 2 E741 errors.
Why it was not caught before
Previous responder runs either:
- Failed to find review comments at all (MCP bug — see bug: responder agent cannot read PR review threads — MCP returns empty, curl not attempted #180) and pushed no code
- Pushed code that happened to pass ruff by luck (run 23332736595 on PR fix: render_live_sessions shows active fields for resumed sessions (#139) #172 — 87-line patch, clean code)
This is the first time the responder pushed code that actually violated a ruff rule, exposing the gap.
Root cause
The network.allowed config in review-responder.md had defaults and python but NOT astral.sh:
network:
allowed:
- defaults
- pythonThe python preset covers PyPI (pypi.org, files.pythonhosted.org), but astral.sh is a separate domain used by the Astral toolchain (uv, ruff).
Fix
Already implemented on branch fix/responder-prefetch-comments:
network:
allowed:
- defaults
- python
- "astral.sh"This will be included in the pre-fetch PR (not yet created).
Affected workflows
review-responder.md— fixed on branchci-fixer.md— haspythonbut NOTastral.sh— needs fixissue-implementer.md— haspythonbut NOTastral.sh— needs fixcode-health.md—defaultsonly — may need fix if it runs lintquality-gate.md—defaultsonly — may need fix if it runs linttest-analysis.md—defaultsonly — may need fix if it runs lint
See audit issue for full investigation.