Skip to content

feat: quality gate closes poor-quality PRs + align gh-aw to v0.60.0#140

Merged
microsasa merged 2 commits intomainfrom
fix/quality-gate-close
Mar 17, 2026
Merged

feat: quality gate closes poor-quality PRs + align gh-aw to v0.60.0#140
microsasa merged 2 commits intomainfrom
fix/quality-gate-close

Conversation

@microsasa
Copy link
Owner

@microsasa microsasa commented Mar 17, 2026

Changes

  1. Quality Gate close capability — Add close-pull-request safe-output to quality-gate workflow. When code quality is poor, the gate closes the PR with an explanation instead of just commenting. The source issue stays open for implementer retry.

  2. gh-aw version alignment — Update copilot-setup-steps.yml from v0.58.1 to v0.60.0, matching the local CLI compiler. All lock files recompiled with v0.60.0.

Note: Lock files (.lock.yml) are compiler-generated output from gh aw compile — changes in them (e.g. action pin format) reflect gh-aw compiler behavior, not manual edits.

Closes #89.

Copilot AI review requested due to automatic review settings March 17, 2026 16:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the repo’s Quality Gate gh-aw workflow so it can close poor-quality pull requests (with an explanatory closing comment) rather than only leaving feedback, aligning with Issue #89.

Changes:

  • Add close-pull-request to safe-outputs in .github/workflows/quality-gate.md.
  • Update the Quality Gate instructions to close PRs when code quality is poor (leaving the source issue open for retry).
  • Regenerate quality-gate.lock.yml to include the close_pull_request tool and handler configuration.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/quality-gate.md Adds close-pull-request safe-output and updates policy text for poor-quality PR handling.
.github/workflows/quality-gate.lock.yml Regenerates compiled workflow to include close_pull_request safe-output tooling/config (but also changes the pinned setup action version).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@microsasa microsasa force-pushed the fix/quality-gate-close branch from d49882d to c47d094 Compare March 17, 2026 16:55
Add close-pull-request safe-output to quality-gate. When code quality
is poor, the gate closes the PR with an explanation instead of just
commenting. The source issue stays open for implementer retry.

Recompiles all lock files with gh-aw v0.60.0.

Closes #89.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 17, 2026 17:00
@microsasa microsasa force-pushed the fix/quality-gate-close branch from c47d094 to 620cac4 Compare March 17, 2026 17:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the automation “Quality Gate” to actively close poor-quality agent-created pull requests, and regenerates several gh-aw workflow lockfiles as part of the compilation/upgrade.

Changes:

  • Add close-pull-request safe-output to the Quality Gate workflow and update its decision instructions accordingly.
  • Regenerate multiple gh-aw .lock.yml workflows with gh-aw v0.60.0 / AWF v0.24.2, including updated MCP guard policy wiring and safe-outputs tool generation.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
.github/workflows/quality-gate.md Adds close-pull-request safe-output and updates guidance to close poor-quality PRs.
.github/workflows/quality-gate.lock.yml Compiled workflow updates including new close_pull_request safe-output wiring and broader gh-aw v0.60.0 regen.
.github/workflows/review-responder.lock.yml Regenerated lockfile for gh-aw v0.60.0 (setup/action references, safe-outputs generation, MCP config changes).
.github/workflows/issue-implementer.lock.yml Regenerated lockfile for gh-aw v0.60.0 (setup/action references, safe-outputs generation, MCP config changes).
.github/workflows/ci-fixer.lock.yml Regenerated lockfile for gh-aw v0.60.0 (setup/action references, safe-outputs generation, MCP config changes).
.github/workflows/code-health.lock.yml Regenerated lockfile for gh-aw v0.60.0 (setup/action references, safe-outputs generation, MCP config changes).
.github/workflows/test-analysis.lock.yml Regenerated lockfile for gh-aw v0.60.0 (setup/action references, safe-outputs generation, MCP config changes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The setup-cli action SHA was already pinned to v0.60.0 but the
version parameter still specified v0.58.1. Aligns with the local
CLI compiler version used to generate lock files.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@microsasa microsasa changed the title feat: quality gate closes poor-quality PRs feat: quality gate closes poor-quality PRs + align gh-aw to v0.60.0 Mar 17, 2026
@microsasa microsasa merged commit 877dbd6 into main Mar 17, 2026
80 of 81 checks passed
@microsasa microsasa deleted the fix/quality-gate-close branch March 17, 2026 17:37
microsasa pushed a commit that referenced this pull request Mar 17, 2026
- Changelog: added entries for PRs #140-#143, dependabot bumps,
  orchestrator v1/v2, PR #113 auto-merge success
- Agentic-workflows: replaced removed orchestrator section with
  current bash implementation, updated agent inventory, added
  history entry
- Test-analysis: changed cron from weekly to daily (0 9 * * *)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsasa pushed a commit that referenced this pull request Mar 19, 2026
Changelog: added entries for orchestrator v1/v2 (PRs #140-#143),
the v3/responder/trigger-disable reverts, and key discoveries.

Agentic-workflows: updated orchestrator section (v1+v2 on main,
v3 reverted), responder status (target '*' fix, workflow_dispatch),
agent inventory (added orchestrator, updated responder/quality-gate),
history (3 new entries covering March 17-18), and 3 new pitfalls
(safe output target, review trigger loops, over-specifying agents).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quality Gate: close poor-quality PRs with close-pull-request safe-output

2 participants