Skip to content

fix: responder uses gh api graphql to read review threads#147

Merged
microsasa merged 1 commit intomainfrom
fix/responder-graphql-threads
Mar 17, 2026
Merged

fix: responder uses gh api graphql to read review threads#147
microsasa merged 1 commit intomainfrom
fix/responder-graphql-threads

Conversation

@microsasa
Copy link
Owner

@microsasa microsasa commented Mar 17, 2026

Reverts the review-responder to the original simple instructions that successfully addressed review threads (run 23117978475, 2026-03-15). Multiple rounds of CLI-driven churn broke the responder's ability to read threads by over-specifying how to query them.

Only changes from the known-working version:

  1. Removed resolve-pull-request-review-thread safe-output (orchestrator handles this now)
  2. Kept if: label gate (saves compute on non-aw PRs)
  3. Added NOTE about thread resolution being handled by orchestrator

Closes #148

Copilot AI review requested due to automatic review settings March 17, 2026 22:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Review Responder workflow instructions to use gh api graphql for fetching unresolved review threads (instead of MCP tooling), and adjusts the label/processing sequence to avoid adding loop-guard labels when there’s nothing to address.

Changes:

  • Replaces the “check review comments / threads” step with a GraphQL-based gh api graphql query and JSON filtering instructions.
  • Reorders the loop-guard label logic so review-response-attempted is only applied after confirming unresolved threads exist.
  • Updates the per-thread handling instructions to rely on the GraphQL thread data (path/line/body).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@microsasa microsasa force-pushed the fix/responder-graphql-threads branch 2 times, most recently from 1052fdf to 5a14e5c Compare March 17, 2026 22:34
Copilot AI review requested due to automatic review settings March 17, 2026 22:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Review Responder gh-aw workflow instructions to change when the workflow stops, how it guards against loops, and how it sequences label application vs. processing review threads.

Changes:

  • Simplifies the “no-comment review” handling by stopping immediately when the triggering review has no inline comments.
  • Reorders loop-guard labeling (review-response-attempted) to occur earlier in the process.
  • Adjusts the unresolved-thread handling instructions (including the “>10 threads” guidance) and trims push/reply guidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Reverts the review-responder to the original simple instructions
that successfully addressed review threads (run 23117978475,
2026-03-15). Multiple rounds of 'improvements' broke the
responder's ability to read threads — over-specifying how to
query threads (GraphQL, MCP) instead of letting the agent figure
it out, and changing step ordering that prevented thread discovery.

Only change from the known-working version: removed resolve-thread
safe-output (now handled by the pipeline orchestrator) and kept
the if: label gate (saves compute on non-aw PRs).

Closes #148

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@microsasa microsasa force-pushed the fix/responder-graphql-threads branch from 5a14e5c to fd42698 Compare March 17, 2026 22:39
@microsasa microsasa merged commit a114a8b into main Mar 17, 2026
44 checks passed
@microsasa microsasa deleted the fix/responder-graphql-threads branch March 17, 2026 22:51
microsasa pushed a commit that referenced this pull request Mar 18, 2026
…threads"

This reverts commit a114a8b, reversing
changes made to 7fb47a6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: review-responder cannot see review threads — noop on every run

2 participants