Skip to content

fix: orchestrator quality gate timing — rebase ordering, Copilot review request, in-flight check#212

Merged
microsasa merged 2 commits intomainfrom
fix/rebase-before-quality-gate
Mar 21, 2026
Merged

fix: orchestrator quality gate timing — rebase ordering, Copilot review request, in-flight check#212
microsasa merged 2 commits intomainfrom
fix/rebase-before-quality-gate

Conversation

@microsasa
Copy link
Owner

@microsasa microsasa commented Mar 21, 2026

Fixes

#211 — Race condition: quality gate dispatched before rebase

Check mergeStateStatus before step 4. If PR is BEHIND or DIRTY, skip quality gate — the rebase step handles it, next cycle dispatches on rebased commit.

#203 — No fallback if Copilot review never runs

Proactively request Copilot review via gh pr edit --add-reviewer @copilot when no review exists on current commit. Safe to call repeatedly — if review is in progress, request is ignored.

#213 — Duplicate quality gate dispatches

Check if quality gate is already in_progress/queued/waiting before dispatching. Same pattern as implementer in-flight check (#164/#190).

Commits

  1. fix: skip quality gate dispatch if PR needs rebase — mergeStateStatus check
  2. fix: request Copilot review if missing + check quality gate in-flight — proactive review request + duplicate dispatch guard
  3. docs: update changelog and pitfalls — pitfalls [aw][code health] Test hygiene bundle: unused _NOW constant and CI coverage scope mismatch #32-34

Fixes #211, #203, #213

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: orchestrator dispatches quality gate before rebase — race condition

2 participants