fix: issue-implementer protected file fallback and PR iteration#37
Merged
fix: issue-implementer protected file fallback and PR iteration#37
Conversation
- Add protected-files: fallback-to-issue so protected file changes create a review issue instead of failing silently - Add push-to-pull-request-branch so the implementer can iterate on its own PRs (CI failures, review feedback) Closes #34 Closes #36 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsasa
force-pushed
the
fix/implementer-improvements
branch
from
a00979f to
fd56b14
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds two improvements to the issue-implementer GitHub Actions workflow: (1) a fallback-to-issue policy when the implementer tries to modify protected files, and (2) a new push-to-pull-request-branch safe output so the implementer can iterate on its own PRs (e.g., to fix CI failures).
Changes:
- Added
protected-files: fallback-to-issueto thecreate-pull-requestsafe output and added thepush-to-pull-request-branchsafe output in the workflow frontmatter. - Updated the compiled lock file to include the new tool definition, validation schema, handler configuration, conditional steps, and outputs for
push_to_pull_request_branch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/issue-implementer.md |
Adds protected-files: fallback-to-issue and new push-to-pull-request-branch safe output to frontmatter |
.github/workflows/issue-implementer.lock.yml |
Compiled lock file updated with new tool, validation, config, conditionals, and outputs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two improvements to the issue-implementer workflow:
Protected file fallback — when the implementer tries to modify protected files (CI config, agent instructions), it now creates a review issue instead of failing silently.
PR iteration — adds push-to-pull-request-branch so the implementer can push fixes to its own PRs when CI fails or review feedback comes in.
Related: #35
Closes #34
Closes #36