Skip to content

test: add coverage for pure active session with no model_metrics (#78) #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microsasa merged 1 commit into from
Mar 15, 2026
Merged

test: add coverage for pure active session with no model_metrics (#78) #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions tests/copilot_usage/test_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,6 +1325,44 @@ def test_resumed_session_no_double_count(self) -> None:
assert grand_match is not None, "Grand Total row not found"
assert grand_match.group(1) == "10"

def test_pure_active_session_no_metrics_shows_both_rows(self) -> None:
"""Active session with no model_metrics shows placeholder row AND Since-last-shutdown row."""
session = SessionSummary(
session_id="pure-active-1234",
name="Just Started",
model="claude-sonnet-4",
start_time=datetime(2025, 1, 15, 10, 0, tzinfo=UTC),
is_active=True,
model_calls=2,
user_messages=1,
active_model_calls=2,
active_output_tokens=300,
# model_metrics intentionally empty
)
output = _capture_cost_view([session])
assert "Just Started" in output
assert "—" in output # placeholder row (no metrics)
assert "Since last shutdown" in output # active row
assert "N/A" in output

def test_pure_active_no_metrics_grand_total_includes_active_tokens(self) -> None:
"""Grand total output tokens includes active_output_tokens for no-metrics active session."""
session = SessionSummary(
session_id="pure-active-5678",
name="Token Check",
model="claude-sonnet-4",
start_time=datetime(2025, 1, 15, 10, 0, tzinfo=UTC),
is_active=True,
model_calls=1,
user_messages=1,
active_model_calls=1,
active_output_tokens=1500,
)
output = _capture_cost_view([session])
assert "Grand Total" in output
# 1500 output tokens → formatted as "1.5K"
assert "1.5K" in output
Comment on lines +1361 to +1364
Copy link
Owner Author

@microsasa microsasa Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — the original assertion "1.5K" in output would match the "↳ Since last shutdown" row and pass even if the Grand Total row were wrong.

Fixed by following the same pattern as test_resumed_session_no_double_count: stripping ANSI codes and using a regex to specifically target the Output Tokens column of the Grand Total row:

clean = re.sub(r"\x1b\[[0-9;]*m", "", output)
grand_match = re.search(
    r"Grand Total\s*│[^│]*│[^│]*│[^│]*│[^│]*│\s*([\d.]+K?)\s*", clean
)
assert grand_match is not None, "Grand Total row not found"
assert grand_match.group(1) == "1.5K"

All 383 tests pass, coverage remains at 96.65%.

Generated by Review Responder for issue #85

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • astral.sh

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "astral.sh"

See Network Configuration for more information.



class TestRenderFullSummaryHelperReuse:
"""Verify _render_historical_section delegates to shared table helpers."""
Expand Down
Loading