Greenboot fails with "failed to read mount info" on Fedora 43

[ggiguash]

Greenboot fails with "failed to read mount info" on Fedora 43.
This happens in the end of the procedure after all the user checks passed.

Nov 25 13:46:11 microshift-okd-1 greenboot[3370]: Error: Failed to check boot mount state: Failed to read mount info

[say-paul]

RCA: fedora-iot/greenboot-rs#132

[runcom]

I'll throw my doubts here as well, what's the point of greenboot running in a container (if I understand the issue from the slack chat). Are you running bootc upgrade/switch inside the container? why?

[ggiguash]

I'll throw my doubts here as well, what's the point of greenboot running in a container (if I understand the issue from the slack chat). Are you running bootc upgrade/switch inside the container? why?

We do not expect greenboot to work in any container, but we do expect it to work when systemd-based boot sequence is run. In case of bootc, this is also when it's run as a container.
Let's also mention the backward compatibility aspect here. It's been working fine in bootc containers until F43.

[runcom]

I'll throw my doubts here as well, what's the point of greenboot running in a container (if I understand the issue from the slack chat). Are you running bootc upgrade/switch inside the container? why?

We do not expect greenboot to work in any container, but we do expect it to work when systemd-based boot sequence is run. In case of bootc, this is also when it's run as a container. Let's also mention the backward compatibility aspect here. It's been working fine in bootc containers until F43.

yup, @say-paul understands why already so a fix it's on its way for F43 - thanks!

[say-paul]

Even if we skip the boot remount check, greenboot service's will still counter failure as it tries to set grub variable which is hard coded to /boot/grub2/grubenv (same with bash greenboot ).
We can mock for testing but that doesn't make much sense as containers will never have grubenv to which greenboot refers to.
@ggiguash is this an actual microshift use-case? a solution for this can be to skip updating grub vars as well for containers , greenboot only does health-checks, but that does not do restarts and rollback.

[ggiguash]

@say-paul , yes, it is how we test MicroShift upstream - inside bootc containers.
We need to make it work in the bootc container to preserve backward compatibility. I think rollbacks in containers are not necessary.

[say-paul]

Okay, greenboot in containers will only do health-check.
Reboots and rollback will not be triggered (appropriate log will be added) .

[ggiguash]

Testing the fixed greenboot package seems to have produced positive results.
See fedora-iot/greenboot-rs#132 (comment)

[ggiguash]

The new greenboot-0.16.z package made it into CentOS 9 and 10 Streams. Need to implement a w/a until we get a fix.