feat: add redirect URIs and remove unused config option#394
Merged
ragurubhaarath merged 7 commits intomainfrom Apr 30, 2026
Merged
feat: add redirect URIs and remove unused config option#394ragurubhaarath merged 7 commits intomainfrom
ragurubhaarath merged 7 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…command Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the register-external-mcp-server flow to register additional OAuth redirect URIs for the PublicClients Entra app, and removes an unused CLI option (--config / -c) from the command surface.
Changes:
- Add
https://vscode.dev/redirectandhttp://localhostto the PublicClients app redirect URIs update call. - Remove the unused
--config/-coption from theregister-external-mcp-serversubcommand and update tests accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/DevelopMcpCommandTests.cs | Updates CLI option assertions to reflect removal of --config. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/RegisterCommandExecutor.cs | Extends redirect URI list sent to Graph for PublicClients app registration. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopMcpCommand.cs | Removes the unused --config / -c option from the subcommand definition. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Detect database constraint violation from the API and display a clean user-facing message instead of raw error details. Raw details are still available with --verbose. Also demote ValidateResponseAsync body-level errors to debug so callers control the user-facing message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pronak657
previously approved these changes
Apr 30, 2026
… error, correlation ID at warning Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pronak657
previously approved these changes
Apr 30, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pronak657
approved these changes
Apr 30, 2026
biswapm
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://vscode.dev/redirectandhttp://localhostredirect URIs to the PublicClients Entra app duringregister-external-mcp-server--config/-coption fromregister-external-mcp-servercommand (was never wired to anything, cluttered--helpoutput)Test plan
a365 develop-mcp register-external-mcp-server --helpand verify--configno longer appears🤖 Generated with Claude Code