Agent 365 observability instructions: full rewrite to support all languages#396
Merged
sellakumaran merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
…of truth - Rewrites the guide as a phased, idempotent skill covering .NET, Node.js, and Python - Supports AI Teammate (OBO) and autonomous (S2S/FMI 3-hop) auth flows - Documents all known SDK workarounds (useS2SEndpoint, MSAL fmiPath, Python kwargs crash) - Adds authoritative reference docs for each language under references/
sellakumaran
changed the title
github-actions
Bot
added
the
documentation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds new “authoritative reference” docs and rewrites the guided setup into a phased, idempotent skill for wiring Agent 365 observability across .NET, Node.js, and Python (including OBO and S2S/FMI flows), with documented SDK workarounds.
Changes:
- Introduces new language-specific observability reference docs (Python/Node.js/.NET) with package lists, examples, and troubleshooting.
- Rewrites
a365-observability-instructions.mdinto a multi-phase, cache-driven “skill” workflow with install/wire/validate steps. - Documents known SDK issues/workarounds for S2S endpoints, FMI token acquisition, and instrumentation ordering.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 14 comments.
| File | Description |
|---|---|
| docs/agent365-guided-setup/references/python-observability.md | New Python reference including unified distro init, OBO caching, and S2S 3-hop FMI token service patterns |
| docs/agent365-guided-setup/references/nodejs-observability.md | New Node.js reference with unified distro init, OBO hosting helpers, and S2S FMI token service + exporter workarounds |
| docs/agent365-guided-setup/references/dotnet-observability.md | New .NET reference covering OBO/hosting and S2S/unified distro wiring plus known SDK issues |
| docs/agent365-guided-setup/a365-observability-instructions.md | Full rewrite into phased “skill” instructions (detection cache, install, wiring, config, build validation, test) |
Comments suppressed due to low confidence (1)
docs/agent365-guided-setup/references/nodejs-observability.md:1
- The doc claims MSAL Node does not serialize
fmiPathin any published version, but the MSI code path still relies onacquireTokenByClientCredential({ fmiPath }). If the limitation statement is accurate, this sample will fail for MSI too (not just client-secret), contradicting the guidance. Either (a) update the sample to use the same direct HTTP POST workaround for the MSI→Blueprint hop, or (b) narrow/correct the limitation statement to explain why MSI path is expected to work despite the generalfmiPathserialization issue.
# Node.js — A365 Observability Reference
- Switch .NET, Node.js, and Python install/setup to new unified SDKs and update all import paths - Clarify .NET OBO vs S2S install paths and warn against direct Hosting/Runtime refs - Add @microsoft/opentelemetry to Node.js, improve token service shutdown - Use microsoft-opentelemetry for Python, remove version pre-flight, clarify S2S deps - Expand Phase 5.5: require full source scan for scope instrumentation, present summary table for user confirmation, and detail language-specific scope rules - Remove old auto-instrumentation prompt; new process is user-confirmed and mandatory - Clarify MSAL FMI path workaround in Node.js docs - Update all code samples and checks to use new package structure
ajmfehr
approved these changes
Apr 30, 2026
gwharris7
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.