Fix duplicate agent registration; add preview nudge; bump to GA 1.1#398
Merged
sellakumaran merged 2 commits intomainfrom May 1, 2026
Merged
Fix duplicate agent registration; add preview nudge; bump to GA 1.1#398sellakumaran merged 2 commits intomainfrom
sellakumaran merged 2 commits intomainfrom
Conversation
- setup all --agent-name: merge AgentRegistrationId from a365.generated.config.json on bootstrap re-runs so the stored ID is used for idempotency, preventing duplicate POST to copilot/agentRegistrations when the same agent is set up more than once - setup all: skip registration with a warning when AgenticAppId is empty, instead of silently posting an invalid request; directs user to retry with --agent-registration-only - Version check: add SelectLatestVersions for channel-aware filtering — stable users see stable as primary update target; informational preview nudge shown when a newer preview exists above the latest GA, without triggering the update-required banner - Bump version.json from 1.1-preview to 1.1.0 for GA release Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves a365 setup all idempotency for agent registration, enhances the CLI version-check experience with channel-aware update targeting plus an informational preview nudge, and promotes the CLI from 1.1-preview to 1.1.0 GA.
Changes:
- Prevent duplicate agent registration by reusing a previously stored
AgentRegistrationIdduring bootstrap re-runs (--agent-name) and by skipping registration whenAgenticAppIdis missing (with a warning and retry guidance). - Add channel-aware version selection so stable users target the latest stable release, while optionally seeing a non-blocking “newer preview available” notice.
- Bump
version.jsonto1.1.0and document the changes inCHANGELOG.md.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/version.json | Bumps the CLI version to 1.1.0 (GA). |
| src/Microsoft.Agents.A365.DevTools.Cli/Services/VersionCheckService.cs | Returns both primary latest + optional newer preview from NuGet and caches both. |
| src/Microsoft.Agents.A365.DevTools.Cli/Services/Internal/VersionCheckHelper.cs | Adds SelectLatestVersions to apply channel-aware filtering and compute preview nudge. |
| src/Microsoft.Agents.A365.DevTools.Cli/Models/VersionCheckModels.cs | Extends version check result/cache models to carry NewerPreviewVersion. |
| src/Microsoft.Agents.A365.DevTools.Cli/Program.cs | Prints an informational preview-available message when appropriate. |
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Services/VersionCheckServiceTests.cs | Adds unit tests for channel-aware version selection. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/AllSubcommand.cs | In bootstrap mode, merges AgentRegistrationId from generated config to support idempotency. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/NonDwBlueprintSetupOrchestrator.cs | Skips agent registration with a warning when AgenticAppId is missing. |
| CHANGELOG.md | Documents the new version-check behavior and setup fixes. |
- Refactor agent registration error handling for better reporting and reuse of warning messages. - Update version selection logic to avoid suggesting previews with the same base version as GA; only nudge for strictly higher-base previews. - Add tests to verify correct preview suggestion behavior. - Change version.json from "1.1.0" to "1.1" for precision consistency.
fpfp100
approved these changes
May 1, 2026
ajmfehr
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's what the output looks like with the corrected nudge logic:
Case A — New stable release available
A newer version is available with bug fixes and improvements.
Current: 1.1.12
Latest: 1.2.0
What's new: https://github.com/microsoft/Agent365-devTools/releases
To update, run: dotnet tool update -g Microsoft.Agents.A365.DevTools.Cli
(yellow — LogWarning)
Case B — On latest stable, newer preview with a higher base version
e.g. current = 1.1.0, NuGet has 1.1.0 + 1.2.0-preview.1:
A preview release is also available: 1.2.0-preview.1
To try it: dotnet tool update -g Microsoft.Agents.A365.DevTools.Cli --prerelease
(default/white — LogInformation)
Case B — same-base preview, no nudge (the fix in the staged diff)
e.g. current = 1.1.0, NuGet has 1.1.0 + 1.1.0-preview.50:
(no output)