Correctly read url parameter of ToolingManifest.json when the file is read from disk.#147
Merged
tmlsousa merged 2 commits intomicrosoft:mainfrom Dec 28, 2025
Merged
Conversation
Contributor
Author
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ParseServerConfigFromManifest to correctly read the url parameter from ToolingManifest.json files, enabling custom MCP server URLs to be configured. Previously, the method only supported first-party Agent 365 tools by defaulting to a base URL. The changes align the manifest parsing logic with the existing ParseServerConfig method.
Key Changes:
- Added parsing of the
urlproperty from ToolingManifest.json - Added fallback logic to read
mcpServerUniqueNamewhenmcpServerNameis not present - Modified URL construction to use provided URL or fall back to building one from the server name
pontemonti
approved these changes
Dec 27, 2025
rahuldevikar761
approved these changes
Dec 27, 2025
tmlsousa
approved these changes
Dec 27, 2025
This was referenced Dec 27, 2025
This was referenced Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseServerConfigFromManifestdoes not currently read theurlproperty of theToolingManifest.jsonfile, instead it defaults to a base url that only works for first-party Agent 365 tools.When using the A365 MCP Management MCP Server to create custom MCP Servers, the URL of such a server needs to be configured in the
ToolingManifest.jsonfile. Example:{ "mcpServers": [ { "mcpServerName": "mcp_MailTools", "mcpServerUniqueName": "mcp_MailTools" } ... { "mcpServerName": "adde_mycoolmcpserver", "mcpServerUniqueName": "adde_mycoolmcpserver", "scope": "McpServers.DataverseCustom.All", "url": "https://agent365.svc.cloud.microsoft/mcp/environments/f828e740-6703-e4e7-b631-11a48500a013/servers/adde_mycoolmcpserver" } ] }This PR fixes this, and also aligns the code in
ParseServerConfigFromManifestwithParseServerConfig.