Skip to content

Remove fragile error handling from sendChatHistory methods #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pontemonti merged 2 commits into from
Jan 27, 2026
Merged

Remove fragile error handling from sendChatHistory methods #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea5673
Initial plan
Copilot Jan 27, 2026
fbe6c0c
Remove fragile 'is required' check from sendChatHistory methods
Copilot Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 19 additions & 33 deletions packages/agents-a365-tooling-extensions-openai/src/McpToolRegistrationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import { v4 as uuidv4 } from 'uuid';
import { McpToolServerConfigurationService, Utility, ToolOptions, ChatHistoryMessage } from '@microsoft/agents-a365-tooling';
import { AgenticAuthenticationService, Utility as RuntimeUtility, OperationResult, OperationError } from '@microsoft/agents-a365-runtime';
import { AgenticAuthenticationService, Utility as RuntimeUtility, OperationResult } from '@microsoft/agents-a365-runtime';

// Agents SDK
import { TurnContext, Authorization } from '@microsoft/agents-hosting';
Expand Down Expand Up @@ -117,22 +117,15 @@ export class McpToolRegistrationService {
throw new Error('session is required');
}

try {
// Extract messages from session
const items = await session.getItems(limit);

// Delegate to the list-based method
return await this.sendChatHistoryMessagesAsync(
turnContext,
items,
toolOptions
);
} catch (err) {
if (err instanceof Error && err.message.includes('is required')) {
throw err; // Re-throw validation errors
}
return OperationResult.failed(new OperationError(err as Error));
}
// Extract messages from session
const items = await session.getItems(limit);

// Delegate to the list-based method
return await this.sendChatHistoryMessagesAsync(
turnContext,
items,
toolOptions
);
}

/**
Expand Down Expand Up @@ -178,22 +171,15 @@ export class McpToolRegistrationService {
orchestratorName: toolOptions?.orchestratorName ?? this.orchestratorName
};

try {
// Convert OpenAI messages to ChatHistoryMessage format
const chatHistoryMessages = this.convertToChatHistoryMessages(messages);

// Delegate to core service
return await this.configService.sendChatHistory(
turnContext,
chatHistoryMessages,
effectiveOptions
);
} catch (err) {
if (err instanceof Error && err.message.includes('is required')) {
throw err; // Re-throw validation errors
}
return OperationResult.failed(new OperationError(err as Error));
}
// Convert OpenAI messages to ChatHistoryMessage format
const chatHistoryMessages = this.convertToChatHistoryMessages(messages);

// Delegate to core service
return await this.configService.sendChatHistory(
turnContext,
chatHistoryMessages,
effectiveOptions
);
}

/**
Expand Down