Skip to content

Remove TextCompletion and GenerateContent from InferenceOperationType and GEN_AI_OPERATION_NAMES #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −9
Open

Remove TextCompletion and GenerateContent from InferenceOperationType and GEN_AI_OPERATION_NAMES #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
576da62
Initial plan
Copilot Apr 27, 2026
3481730
Remove TextCompletion and GenerateContent from InferenceOperationType…
Copilot Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/agents-a365-observability/docs/design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,9 +451,7 @@ enum InvocationRole {
}

enum InferenceOperationType {
CHAT = 'Chat',
TEXT_COMPLETION = 'TextCompletion',
GENERATE_CONTENT = 'GenerateContent'
CHAT = 'Chat'
}
```

Expand Down
4 changes: 1 addition & 3 deletions packages/agents-a365-observability/src/tracing/contracts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ export enum InvocationRole {
* Represents different operation for types for model inference
*/
export enum InferenceOperationType {
CHAT = 'Chat',
TEXT_COMPLETION = 'TextCompletion',
GENERATE_CONTENT = 'GenerateContent'
CHAT = 'Chat'
}

/**
Expand Down
2 changes: 0 additions & 2 deletions packages/agents-a365-observability/src/tracing/exporter/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ const GEN_AI_OPERATION_NAMES: ReadonlySet<string> = new Set([
OpenTelemetryConstants.OUTPUT_MESSAGES_OPERATION_NAME, // 'output_messages'
OpenTelemetryConstants.CHAT_OPERATION_NAME, // 'chat'
'Chat', // InferenceOperationType.CHAT
'TextCompletion', // InferenceOperationType.TEXT_COMPLETION
'GenerateContent', // InferenceOperationType.GENERATE_CONTENT
]);

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/observability/core/scopes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ describe('Scopes', () => {
it('should create scope with minimal details', () => {
const spy = jest.spyOn(OpenTelemetryScope.prototype as any, 'setTagMaybe');
const inferenceDetails: InferenceDetails = {
operationName: InferenceOperationType.TEXT_COMPLETION,
operationName: InferenceOperationType.CHAT,
model: 'gpt-3.5-turbo'
};

Expand Down
Loading