Exclude hostDetector from default OTel resource detectors#244
Merged
Conversation
The NodeSDK default resource detectors auto-attach host.name and host.arch to every span, leaking machine details into exported telemetry. Explicitly list only envDetector, processDetector, and serviceInstanceIdDetector to exclude hostDetector. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the ObservabilityBuilder’s OpenTelemetry NodeSDK initialization to exclude host-based resource detection so host.* attributes aren’t automatically attached to exported telemetry.
Changes:
- Adds explicit
resourceDetectorsconfiguration to NodeSDK (env/process/serviceInstanceId only) - Updates
@opentelemetry/resourcesimports to include the selected detectors
… detectors Prevents host.name, host.arch, and service.instance.id from leaking into exported telemetry. Keeps envDetector and processDetector. Adds unit test that verifies actual resource attributes on exported spans. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ajmfehr
approved these changes
Apr 30, 2026
alexlu4250
approved these changes
Apr 30, 2026
sellakumaran
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostDetectorfrom theNodeSDKresource detectors inObservabilityBuilderhost.nameandhost.archfrom leaking into exported telemetryenvDetector,processDetector, andserviceInstanceIdDetectorTest plan
host.name/host.archattributes🤖 Generated with Claude Code