Skip to content

Rename TModel TypeVar to _TModel to fix broken doc links #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Rename TModel TypeVar to _TModel to fix broken doc links #240

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bce4079
Initial plan
Copilot Apr 24, 2026
f40ae43
Rename TModel to _TModel to fix broken doc links
Copilot Apr 24, 2026
9013a49
Merge branch 'main' into copilot/fix-broken-links-documentation
JimDaly Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...5-notifications/microsoft_agents_a365/notifications/models/agent_notification_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from .email_reference import EmailReference
from .wpx_comment import WpxComment

TModel = TypeVar("TModel")
_TModel = TypeVar("_TModel")


class AgentNotificationActivity:
Expand Down Expand Up @@ -148,7 +148,7 @@ def notification_type(self) -> Optional[NotificationTypes]:
return self._notification_type

# Generic escape hatch
def as_model(self, model: Type[TModel]) -> Optional[TModel]:
def as_model(self, model: Type[_TModel]) -> Optional[_TModel]:
Comment on lines 150 to +151
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as_model calls model.model_validate(...), but the annotation model: Type[_TModel] doesn’t guarantee that the passed type has a model_validate classmethod. Consider bounding _TModel to pydantic.BaseModel (or using type[BaseModel] directly) so static type checkers can validate correct usage.

Copilot uses AI. Check for mistakes.
"""Parse the activity value as a custom model type.

This method provides a generic way to validate and parse the activity's value
Expand Down
Loading