Conversation
…inTracer docstrings Agent-Logs-Url: https://github.com/microsoft/Agent365-python/sessions/127abf3a-d980-4c99-a838-52445e27f85d Co-authored-by: JimDaly <6353736+JimDaly@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix broken cross-reference links and raw GitHub URLs in CustomLangChainTracer docstrings
Fix broken cross-reference links and raw GitHub URLs in CustomLangChainTracer docstrings
Apr 24, 2026
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CustomLangChainTracer docstrings to improve DocFx-generated API documentation by eliminating unresolved cross-references and removing confusing raw GitHub source links.
Changes:
- Adjusted
__init__docstring to remove parenthesized type annotations in theArgs:section and corrected the initializer title toCustomLangChainTracer. - Rewrote
on_chat_model_startdocstring to replace raw GitHub URLs with a concise explanation and removed the now-unneeded# noqa: E501.
ajmfehr
approved these changes
Apr 28, 2026
JimDaly
approved these changes
Apr 29, 2026
sellakumaran
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocFx-generated API docs for
CustomLangChainTracerproduced unresolved cross-reference warnings and rendered raw GitHub source URLs as confusing literal links.Changes
__init__docstring — Remove Google-style parenthesised type annotations (tracer (trace_api.Tracer):,*args (Any):, etc.) that DocFx was extracting as unresolvable<xref:…>cross-references. Types are already on the signature. Also corrects the stale title ("OpenInferenceTracer"→"CustomLangChainTracer").on_chat_model_startdocstring — Replace three rawhttps://github.com/langchain-ai/langchain/blob/…URLs (which rendered as implementation-internal hyperlinks in published docs) with a concise plain-text explanation of why the method delegates toLangChainTracer. Removes the now-unnecessary# noqa: E501.